Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore event sent to webhooks #6905

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix restore event sent to webhooks #6905

merged 1 commit into from
Sep 5, 2024

Conversation

FelixMalfait
Copy link
Member

We were sending the wrong event when restoring a record (delete instead of create)

@FelixMalfait FelixMalfait merged commit bc8c961 into main Sep 5, 2024
3 of 4 checks passed
@FelixMalfait FelixMalfait deleted the fix-restore-event branch September 5, 2024 12:21
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses an important issue in the webhook event handling for record restoration in the Twenty application. Here's a concise summary of the changes and their implications:

  • Fixed incorrect webhook event for record restoration in WorkspaceQueryRunnerService
  • Changed CallWebhookJobsJobOperation from delete to create in restoreMany method
  • Aligns webhook event with the actual operation of re-creating a restored record
  • Ensures consistency between internal operations and external webhook notifications
  • Improves accuracy of event tracking for integrations relying on webhook data

The change is logical and appears to correctly represent the nature of the restore operation. However, to ensure full consistency, it's recommended to review related webhook handling code, particularly in CallWebhookJobsJob and CallWebhookJob, to confirm that the create event is properly processed throughout the system.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant