fix: Deactivate & Activate icons should be swapped UI improvements

[harshit078]

Fix

This fixes the minor UI issue #6795 in which it addressed the following two problems-

1. Fixed the Icon switch
2. Updated the Delete Modal

Screenshots

[greptile-apps]

PR Summary

This pull request addresses UI improvements for field activation/deactivation icons and the delete workspace button, enhancing visual consistency and user understanding.

• Swapped IconArchive with IconArchiveOff for 'Deactivate' action in SettingsObjectFieldActiveActionDropdown
• Changed IconArchiveOff to IconArchive for 'Activate' action in SettingsObjectFieldInactiveActionDropdown
• Updated DeleteWorkspace component: replaced StyledConfirmationButton with Button, added IconTrash, and adjusted styling
• Improved button appearance in DeleteWorkspace to better represent a dangerous action
• Simplified ConfirmationModal import in DeleteWorkspace component

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[FelixMalfait]

I think the icon for archive/unarchive was the right one :)

Good for the button, we can remove the StyledConfirmationButton if it isn't used anywhere anymore. Thanks!

[lucasbordeau]

@Bonapara Should we switch the icons ?

[FelixMalfait]

@lucasbordeau no we shouldn't. But we can merge the button change if we revert the change on icons

[charlesBochet]

LGTM, thank you @harshit078

[github-actions]

Thanks @harshit078 for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter