6382 create a command to add a uservar in the key value pair table for every account which needs to reconnect #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This pull request implements a new command to manage accounts requiring reconnection due to insufficient permissions as part of the upgrade to version 0.23.
- Added
SetUserVarsAccountsToReconnectCommandin/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-set-user-vars-accounts-to-reconnect.command.tsto handle account reconnection across workspaces - Updated
AccountsToReconnectServicein/packages/twenty-server/src/modules/connected-account/services/accounts-to-reconnect.service.tswith new methodaddAccountToReconnectByKeyfor centralized management - Modified
CalendarChannelSyncStatusServiceandMessagingChannelSyncStatusServiceto useAccountsToReconnectServiceinstead of direct user variable manipulation - Updated related modules to include
ConnectedAccountModuleand removeUserVarsModule, reflecting the shift in account management approach
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
Comment on lines
141
to
146
| } catch (error) { | ||
| this.logger.error( | ||
| `Failed to add account to reconnect for workspace ${workspaceId}: ${error.message}`, | ||
| ); | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
style: Consider wrapping the entire loop body in a try-catch to continue processing other accounts if one fails
| @@ -52,6 +56,7 @@ import { ViewModule } from 'src/modules/view/view.module'; | |||
| SetWorkspaceActivationStatusCommand, | |||
| UpdateActivitiesCommand, | |||
| BackfillNewOnboardingUserVarsCommand, | |||
There was a problem hiding this comment.
logic: UpgradeTo0_23Command is duplicated in providers array
packages/twenty-server/src/modules/connected-account/services/accounts-to-reconnect.service.ts
Show resolved
Hide resolved
Weiko
reviewed
Aug 7, 2024
...c/database/commands/upgrade-version/0-23/0-23-set-user-vars-accounts-to-reconnect.command.ts
Outdated
Show resolved
Hide resolved
...c/database/commands/upgrade-version/0-23/0-23-set-user-vars-accounts-to-reconnect.command.ts
Outdated
Show resolved
Hide resolved
...c/database/commands/upgrade-version/0-23/0-23-set-user-vars-accounts-to-reconnect.command.ts
Outdated
Show resolved
Hide resolved
Weiko
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6382
Create SetUserVarsAccountsToReconnectCommand.
This command loops on all workspaces and:
ACCOUNTS_TO_RECONNECTUSER_VARwith a key ofACCOUNTS_TO_RECONNECT_INSUFFICIENT_PERMISSIONSfor all connect accounts with a message channel or calendar channel with statusFAILED_INSUFFICIENT_PERMISSIONS