Added max-height to innerlist to get scrolling behaviour #6541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Added max-height to StyledInnerList in CommandMenu.tsx to enable scrolling for long command menus.
- Modified
packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsxto addmax-heighttoStyledInnerList. - Ensures command menu is scrollable when content exceeds viewport height.
- Improves user experience by allowing access to all items in the command menu.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
FelixMalfait
reviewed
Aug 5, 2024
| @@ -100,6 +100,7 @@ const StyledList = styled.div` | |||
| `; | |||
|
|
|||
| const StyledInnerList = styled.div` | |||
| max-height: calc(100vh - ${({ theme }) => theme.spacing(19)}); | |||
There was a problem hiding this comment.
FYI for whoever reviews this PR ; #6209 (comment)
There was a problem hiding this comment.
Thanks for pointing that out, @FelixMalfait. I switched to using dvh and also adjusted the max-height for mobile screens, which I had missed in the initial commit. I appreciate the feedback—please let me know if this addresses your concern.
FelixMalfait
approved these changes
Aug 5, 2024
|
Thanks @ehconitin for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6538
2024-08-05.15-46-28.mp4