Fixes Remove Compact View From Kanban View Sub Options Menu's ( #6116 ) #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faisal-imtiyaz123
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The update ensures that Kanban-specific options are only displayed when no sub-menu is active, enhancing user experience.
- Added condition to check if
currentMenuis undefined before rendering Kanban view options inpackages/twenty-front/src/modules/object-record/record-index/options/components/RecordIndexOptionsDropdownContent.tsx. - Ensures Kanban-specific options are hidden when a sub-menu is active.
- No security or performance issues identified.
- Important to verify
currentMenumanagement throughout the component lifecycle.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -198,7 +198,7 @@ export const RecordIndexOptionsDropdownContent = ({ | |||
| </> | |||
There was a problem hiding this comment.
style: Ensure currentMenu state is correctly managed to avoid unintended side effects.
Weiko
approved these changes
Jul 30, 2024
|
Thanks @Faisal-imtiyaz123 for your contribution! |
charlesBochet
pushed a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6116