Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move folder #6451

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Move folder #6451

merged 1 commit into from
Jul 30, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Jul 30, 2024

Fix folder mistake

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request corrects folder structure mistakes by updating import paths and relocating files within the workflow module.

  • Updated import paths in packages/twenty-server/src/engine/core-modules/workflow/utils/workflow-trigger-graphql-api-exception-handler.util.ts to reflect new directory structure.
  • Corrected import path for WorkflowTriggerService in packages/twenty-server/src/engine/core-modules/workflow/workflow-trigger.module.ts.
  • Updated import path for WorkflowTriggerService in packages/twenty-server/src/engine/core-modules/workflow/workflow-trigger.resolver.ts.
  • Moved workflow-trigger.exception.ts to packages/twenty-server/src/modules/workflow/workflow-trigger/.
  • Relocated workflow-trigger.service.ts to packages/twenty-server/src/modules/workflow/workflow-trigger/.

Ensure all references to these files are updated to prevent runtime errors.

5 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings

@@ -5,7 +5,7 @@ import {
import {
WorkflowTriggerException,
WorkflowTriggerExceptionCode,
} from 'src/modules/workflow/standard-objects/workflow-trigger/workflow-trigger.exception';
} from 'src/modules/workflow/workflow-trigger/workflow-trigger.exception';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Ensure all references to workflow-trigger.exception are updated across the codebase to prevent broken imports.

@@ -1,7 +1,7 @@
import { Module } from '@nestjs/common';

import { WorkflowTriggerResolver } from 'src/engine/core-modules/workflow/workflow-trigger.resolver';
import { WorkflowTriggerService } from 'src/modules/workflow/standard-objects/workflow-trigger/workflow-trigger.service';
import { WorkflowTriggerService } from 'src/modules/workflow/workflow-trigger/workflow-trigger.service';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Ensure the new import path is correct and the service is functioning as expected.

@@ -5,7 +5,7 @@ import { workflowTriggerGraphqlApiExceptionHandler } from 'src/engine/core-modul
import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
import { JwtAuthGuard } from 'src/engine/guards/jwt.auth.guard';
import { WorkflowTriggerService } from 'src/modules/workflow/standard-objects/workflow-trigger/workflow-trigger.service';
import { WorkflowTriggerService } from 'src/modules/workflow/workflow-trigger/workflow-trigger.service';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Ensure that the new import path is correct and that the service is properly defined in the new location.

@@ -2,16 +2,16 @@ import { Injectable } from '@nestjs/common';

import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
import { WorkflowEventListenerWorkspaceEntity } from 'src/modules/workflow/standard-objects/workflow-event-listener.workspace-entity';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Ensure all references to WorkflowEventListenerWorkspaceEntity are updated to the new path.

import {
WorkflowTriggerException,
WorkflowTriggerExceptionCode,
} from 'src/modules/workflow/standard-objects/workflow-trigger/workflow-trigger.exception';
import {
WorkflowDatabaseEventTrigger,
WorkflowTrigger,
WorkflowTriggerType,
WorkflowVersionWorkspaceEntity,
} from 'src/modules/workflow/standard-objects/workflow-version.workspace-entity';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Verify that WorkflowVersionWorkspaceEntity is correctly imported from the new path.

import {
WorkflowTriggerException,
WorkflowTriggerExceptionCode,
} from 'src/modules/workflow/workflow-trigger/workflow-trigger.exception';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Confirm that WorkflowTriggerException and WorkflowTriggerExceptionCode are correctly referenced from the new path.

@charlesBochet charlesBochet merged commit e3496a1 into main Jul 30, 2024
4 of 5 checks passed
@charlesBochet charlesBochet deleted the tt-update-workflow-trigger-folder branch July 30, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants