Replace entityId by recordId in the front end.

[ehconitin]

Hey @lucasbordeau, I replaced every entityId with recordId in the frontend.

Some clarifications:

1. At this line, I changed recordId to selectedRecordId because that component has entityId defined in code at this line which was to be changed to recordId. To avoid repeated constants, I changed the arguments to selectedRecordIds.

2. At the following links:

   • File 1
   • File 2
   • File 3

   It seems to be the tests. As I can see, it is checking for both objectFilterDropdownSelectedEntityIdState and objectFilterDropdownSelectedRecordIdsState. Since entityIds are supposed to be removed and recordedId state is already being checked, I commented out all the entityidState code. If they are to be removed or uncommented, please let me know, and I will do as expected.

[greptile-apps]

PR Summary

Replaced all instances of entityId with recordId across the frontend codebase to standardize identifier terminology.

• Updated CalendarEventDetails.tsx and EventFieldDiffValue.tsx to use recordId in FieldContext.Provider.
• Modified useFieldContext.tsx to replace entityId with recordId in context and state management.
• Commented out objectFilterDropdownSelectedEntityIdState references in useFilterDropdown.ts and useFilterDropdownStates.ts.
• Updated test files like useFilterDropdown.test.tsx and usePersistField.test.tsx to reflect the new recordId terminology.
• Ensured consistency in hooks like useClearField.ts, useInitDraftValueV2.ts, and useIsFieldEmpty.ts by replacing entityId with recordId.

_{30 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[lucasbordeau]

• Could you create a util getRecordFieldInputId that returns ${recordId}-${fieldDefinition?.metadata?.fieldName} from params.
• Could you clean recordId: recordId => recordId,

[lucasbordeau]

Ok we should get rid of objectFilterDropdownSelectedEntityId state, but we should rewrite this test for objectFilterDropdownSelectedRecordIdsState

[ehconitin]

So what should I in this case, keep test cases as it is and create a new issue to rewrite the tests?
What do u suggest?

[lucasbordeau]

Nice job !

[ehconitin]

@lucasbordeau

• Could you create a util getRecordFieldInputId that returns ${recordId}-${fieldDefinition?.metadata?.fieldName} from params.

Yes, Ill work on it.

• Could you clean recordId: recordId => recordId,

I am sorry but could u please give an example on where this should be cleaned up.

[lucasbordeau]

I am sorry but could u please give an example on where this should be cleaned up.

In usePersistField

recordStoreFamilySelector({ recordId: recordId, fieldName }),

To :

recordStoreFamilySelector({ recordId, fieldName }),

[ehconitin]

Got it, my bad should have cleaned in the first place. But will do and let you know.

[ehconitin]

@lucasbordeau

• Could you create a util getRecordFieldInputId that returns ${recordId}-${fieldDefinition?.metadata?.fieldName} from params. - Done
• Could you clean recordId: recordId => recordId. - Done

Could u please review and let me know if there are more changes to be made.

Thanks :)

[FelixMalfait]

@lucasbordeau is off this week so I will merge like this to avoid further conflicts. Great work thanks again!

[github-actions]

Thanks @ehconitin for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter