Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set preselect field type on new field of object page #6314

Conversation

Us3r-gitHub
Copy link
Contributor

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

No major changes found since last review.

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@lucasbordeau lucasbordeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To complete this issue, we should have a way to know that we're creating a select field because we want to create board view, and then go back directly to the board view when we click on "Save" in the field creation form, and not to the settings field list, as it would be the case normally.

@Us3r-gitHub
Copy link
Contributor Author

Thank you for your feedback

go back directly to the board view when we click on "Save"

It makes sense.

By the way, could we implement react router history to address this?
Or perhaps use navigationMemorizedUrlState?

@lucasbordeau
Copy link
Contributor

lucasbordeau commented Jul 22, 2024

By the way, could we implement react router history to address this? Or perhaps use navigationMemorizedUrlState?

Let's use navigationMemorizedUrlState yes !

@Us3r-gitHub Us3r-gitHub force-pushed the feat/kanban/issue-5661/set-preselect-field branch from 5f1f2d1 to d69d345 Compare July 23, 2024 09:02
@FelixMalfait
Copy link
Member

Hey sorry for the very long delay. I removed "navigateBack" not because it wasn't properly implemented but because we're careful not to bloat the API with edges cases and this implem seemed to specific to our use-case and not worth the complexity it adds in code.

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! Sorry for the long delay to review!

@FelixMalfait FelixMalfait merged commit f2aa67b into twentyhq:main Aug 7, 2024
1 of 7 checks passed
Copy link

github-actions bot commented Aug 7, 2024

Thanks @Us3r-gitHub for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants