Fix the "Delete" action on the Kaban view

[pacyL2K19]

This PR

• Fixes "Delete" option in Kanban board contextual menu does not delete #5520
• Created a shared confirmation modal component for the ContextMenu and the ActionBar components to avoid code repetition - with its storybook file

Looking forward to getting feedback @charlesBochet

[greptile-apps]

PR Summary

• Refactored ActionBar to use SharedNavigationModal for confirmation modals
• Updated ContextMenu to use SharedNavigationModal, removed useListenClickOutside hook
• Added Storybook story for SharedNavigationModal
• Introduced SharedNavigationModal component to centralize modal logic

[martmull]

Hey, the right click delete in properly fixed.

But I see a functional issue:

• if i right click on an opportunity the modal appears
• then I click outside to make the modal disapear
• then I select two other opportunities
• then I see the "right click modal" appears near the first opportunity, not at the bottom page like it should

@pacyL2K19 Do you think you can provide a fix for that also?

Thanks

[pacyL2K19]

Hey, the right click delete in properly fixed.

But I see a functional issue:

• if i right click on an opportunity the modal appears
• then I click outside to make the modal disapear
• then I select two other opportunities
• then I see the "right click modal" appears near the first opportunity, not at the bottom page like it should

@pacyL2K19 Do you think you can provide a fix for that also?

Thanks

Sure @martmull
Working on it asap

[pacyL2K19]

Hey, the right click delete in properly fixed.
But I see a functional issue:

• if i right click on an opportunity the modal appears
• then I click outside to make the modal disapear
• then I select two other opportunities
• then I see the "right click modal" appears near the first opportunity, not at the bottom page like it should

@pacyL2K19 Do you think you can provide a fix for that also?
Thanks

Sure @martmull Working on it asap

Hi @martmull, the fix to the above comment has been pushed, please have a look and let me know how you find it

[martmull]

@pacyL2K19 thanks, that is better, but still not exactly the expected behavior.
We want

• the bottom ActionBar to be displayed each time we select an opportunity
• the opportunity actionBar to be displayed when we right click on the opportunity

Enregistrement.de.l.ecran.2024-06-05.a.12.43.00.mov

[pacyL2K19]

@pacyL2K19 thanks, that is better, but still not exactly the expected behavior. We want

• the bottom ActionBar to be displayed each time we select an opportunity
• the opportunity actionBar to be displayed when we right click on the opportunity

Enregistrement.de.l.ecran.2024-06-05.a.12.43.00.mov

Hi @martmull
Just pushed my latest change, we should be good now, please have a look

[pacyL2K19]

Here's what I have
https://www.loom.com/share/1fb6737603b4492687b0814148361829?sid=3eb6366f-4e5f-42c8-9b88-9605ac7015a1

[martmull]

Hey, there is still some edge cases, but it LGTM and the delete modal bahavior is far better than before. Thank you very much!

[github-actions]

	Fails
🚫	node failed.

Log

�[31mError: �[39m RequestError [HttpError]: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 3FC7:2237C8:C5DE19:16C926D:66632624.
    at /home/runner/work/twenty/twenty/node_modules/�[4m@octokit�[24m/request/dist-node/index.js:86:21
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m {
  status: �[33m403�[39m,
  response: {
    url: �[32m'https://api.github.com/search/issues?q=is%3Apr%20author%3ApacyL2K19%20is%3Aclosed%20repo%3Atwentyhq%2Ftwenty&per_page=2&page=1'�[39m,
    status: �[33m403�[39m,
    headers: {
      �[32m'access-control-allow-origin'�[39m: �[32m'*'�[39m,
      �[32m'access-control-expose-headers'�[39m: �[32m'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset'�[39m,
      connection: �[32m'close'�[39m,
      �[32m'content-encoding'�[39m: �[32m'gzip'�[39m,
      �[32m'content-security-policy'�[39m: �[32m"default-src 'none'"�[39m,
      �[32m'content-type'�[39m: �[32m'application/json; charset=utf-8'�[39m,
      date: �[32m'Fri, 07 Jun 2024 15:24:20 GMT'�[39m,
      �[32m'referrer-policy'�[39m: �[32m'origin-when-cross-origin, strict-origin-when-cross-origin'�[39m,
      server: �[32m'GitHub.com'�[39m,
      �[32m'strict-transport-security'�[39m: �[32m'max-age=31536000; includeSubdomains; preload'�[39m,
      �[32m'transfer-encoding'�[39m: �[32m'chunked'�[39m,
      vary: �[32m'Accept-Encoding, Accept, X-Requested-With'�[39m,
      �[32m'x-content-type-options'�[39m: �[32m'nosniff'�[39m,
      �[32m'x-frame-options'�[39m: �[32m'deny'�[39m,
      �[32m'x-github-api-version-selected'�[39m: �[32m'2022-11-28'�[39m,
      �[32m'x-github-media-type'�[39m: �[32m'github.v3; format=json'�[39m,
      �[32m'x-github-request-id'�[39m: �[32m'3FC7:2237C8:C5DE19:16C926D:66632624'�[39m,
      �[32m'x-ratelimit-limit'�[39m: �[32m'30'�[39m,
      �[32m'x-ratelimit-remaining'�[39m: �[32m'30'�[39m,
      �[32m'x-ratelimit-reset'�[39m: �[32m'1717773920'�[39m,
      �[32m'x-ratelimit-resource'�[39m: �[32m'search'�[39m,
      �[32m'x-ratelimit-used'�[39m: �[32m'1'�[39m,
      �[32m'x-xss-protection'�[39m: �[32m'0'�[39m
    },
    data: {
      documentation_url: �[32m'https://docs.github.com/free-pro-team@latest/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits'�[39m,
      message: �[32m'You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 3FC7:2237C8:C5DE19:16C926D:66632624.'�[39m
    }
  },
  request: {
    method: �[32m'GET'�[39m,
    url: �[32m'https://api.github.com/search/issues?q=is%3Apr%20author%3ApacyL2K19%20is%3Aclosed%20repo%3Atwentyhq%2Ftwenty&per_page=2&page=1'�[39m,
    headers: {
      accept: �[32m'application/vnd.github.v3+json'�[39m,
      �[32m'user-agent'�[39m: �[32m'octokit-rest.js/18.12.0 octokit-core.js/3.6.0 Node.js/18.20.3 (linux; x64)'�[39m,
      authorization: �[32m'token [REDACTED]'�[39m
    },
    request: { hook: �[36m[Function: bound bound register]�[39m }
  }
}
danger-results:https://tmp/danger-results-2aa5ce8f.json

Generated by 🚫 dangerJS against 29986cd