Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated: removed gradient from onboarding buttons #5178

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

hnrykm
Copy link
Contributor

@hnrykm hnrykm commented Apr 25, 2024

Fixes #5168

  • Added primaryInverted and primaryInvertedHover to design system.
  • Changed primary button background with a gradient to inverted-flat for both light and dark themes.
  • Hover added to go lighter (consistent with tertiary color of +5 step on GRAY_SCALE).
  • Font color changed from primary to inverted.
  • Modified button border from light to strong.

Two components are still utilizing the button with gradient background - email and chrome extension.
Figma design guidelines show them to be inverted and flat (not gradient).

  • Should I change those as well?
  • Should the gradient style be removed altogether after this has been completed?

Copy link

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against 394ebc1

@hnrykm hnrykm closed this Apr 25, 2024
@hnrykm hnrykm reopened this Apr 25, 2024
@hnrykm
Copy link
Contributor Author

hnrykm commented Apr 25, 2024

My apologies. I'm an overeager new developer. I saw an issue that I thought I could take on and gave it a try even though it was already assigned to someone. I tried to save it as a draft until it was appropriate for me to submit a pull request. It doesn't look like it works that way. I don't mean to step on anyone's toes or bypass your guidelines.

@hnrykm hnrykm marked this pull request as ready for review April 26, 2024 09:24
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries @hnrykm, thank you for your contribution 🙂.
PR LGTM! Thanks!

@Weiko Weiko merged commit 6e87554 into twentyhq:main Apr 29, 2024
9 of 10 checks passed
@hnrykm
Copy link
Contributor Author

hnrykm commented Apr 29, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Onboarding Main button Style
2 participants