Card: Change the management of the inside border-radius

[louismaximepiton]

Fixes #37010.

Couldn't spot any breaking change in the example page, but I haven't dig deeper.

Solution

Make the inner border-radius management universal inside the .card.
Leads to remove some unused classes like .card-img-top and .card-img-bottom.
May lighten the bundle size.

[mdo]

This removes two classes with the top and bottom variants. We'd need to deprecate those instead of remove outright—think you could tackle that?

[louismaximepiton]

Hi mdo,

Not sure to completely understand what it is up to here. Should I mention it in the migration guide ? Should I use some deprecate comments ? Should I update the doc to tell that we don't use use those classes anymore ? It would be very helpful if you could light me up on this !

Thanks in advance !

[mdo]

@louismaximepiton Sorry for the delay! We need to keep the original CSS around unmodified until v6. So let's add those .card-img-top and .card-img-bottom classes back in addition to the new one. Then we can add a deprecate note to the docs (I can handle this) and mention it in the migration guide (I can handle this too).

[louismaximepiton]

No problem, I was busy on my side aswell. I tried something on the scss file, I'm not quite sure of the last commit on two parts:

• scss file: Reintroduced the classes but their behavior too, so people shouldn't notice the changes on normal use cases. I also added a deprecation warning message for those classes. Should I remove the behavior for .card-img-top and .card-img-bottom?
• docs file: Introduced a deprecation message here too based on the .navbar-light one.

May I let you the hand on the migration file ?