Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero out the default margin-bottom on label.custom-file #19915

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Conversation

zalog
Copy link
Contributor

@zalog zalog commented May 16, 2016

Reset the margin-bottom: 0.5rem from <label>.

screen-shot-05-16-16-at-04 59-pm

@cvrebert cvrebert changed the title v4 - .custom-file reset margin-bottom Set margin-bottom on .custom-file May 17, 2016
@cvrebert
Copy link
Collaborator

There's no requirement/guarantee that there will be any help text like in your example. In cases with no help text, I'd think the margin would be desirable.

@cvrebert cvrebert changed the title Set margin-bottom on .custom-file Zero out the default margin-bottom on label.custom-file May 17, 2016
@mdo
Copy link
Member

mdo commented May 17, 2016

There's no requirement/guarantee that there will be any help text like in your example. In cases with no help text, I'd think the margin would be desirable.

I think that'll usually be handled by the parent .form-group.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Oct 28, 2016
@mdo mdo merged commit 2017807 into twbs:v4-dev Oct 28, 2016
@mdo mdo mentioned this pull request Oct 28, 2016
@zalog
Copy link
Contributor Author

zalog commented Oct 28, 2016

Thanks!

@zalog zalog deleted the patch-9 branch October 28, 2016 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Alpha 6
Fixed/Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants