[Fix #17400] Add tests about padding restoration

[Johann-S]

Hi,

It's a fix a for #17400
I added several tests to check :

• If a padding-right is applied when modal is taller than viewport
• If padding-right is removed after that

[Johann-S]

PING @cvrebert
Sorry if it's not you who can review but I don't know which one of the Bootstrap team I can ping

[mdo]

Any recent JS contributors want to review this? Added tests would be rad!

/cc @bardiharborow @Johann-S @cvrebert

[Johann-S]

It's my PR so I'm not sure I'm the good one to review my own PR 😄

[bardiharborow]

@Johann-S, why have you used all three classes separated by commas ($('.navbar-fixed-top, .navbar-fixed-bottom, .is-fixed'). You should only need one selector, or am I misunderstanding?

[Johann-S]

Yes you're right I can change that to : $('.navbar-fixed-top.navbar-fixed-bottom.is-fixed')

[bardiharborow]

@Johann-S, I actually meant change it to $('.navbar') and add .navbar to the div, which I believe it should have anyway.

[Johann-S]

Sorry I made this in 2015 so it's a bit difficult for me to dig in 😄

I chose this selector because of : https://github.com/twbs/bootstrap/blob/v4-dev/js/src/modal.js#L70 and https://github.com/twbs/bootstrap/blob/v4-dev/js/src/modal.js#L419-L422

So if it's not a fixed navbar they aren't any padding added to the body.

For information theses tests are for this PR : #17457

[mdo]

Sorry I made this in 2015

Might how time flies! 😅