Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quality measure 0034 timeout fix #515

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

bradmontierth
Copy link
Contributor

Describe your changes

Please include a summary of any changes.
replace OR in inner join with 2 separate inner join statements in CTEs
replace BETWEEN with explicit >= <=

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.
fixed timeout issue at client, runs in 1 minute.

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

Copy link
Member

@sarah-tuva sarah-tuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah-tuva sarah-tuva merged commit 8fc1655 into main Jun 26, 2024
5 checks passed
@sarah-tuva sarah-tuva deleted the quality_measure_timeout branch June 26, 2024 18:35
@sarah-tuva sarah-tuva added the bug Something isn't working label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants