Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eligibility bug #5

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix eligibility bug #5

merged 1 commit into from
Dec 6, 2022

Conversation

sarah-tuva
Copy link
Member

@sarah-tuva sarah-tuva commented Dec 5, 2022

Describe your changes

Fixed a bug in the eligibility model for missing demographics.

How has this been tested?

Tested in Snowflake using the Medicare LDS SAF dataset.

Checklist before requesting a review

  • I have recorded a Loom performing a self-review of my code
  • My code follows style guidelines
  • I have commented my code as necessary
  • I have testing by code by running dbt build in the following warehouse(s):
    • Snowflake
    • Redshift
    • BigQuery
  • I have implemented generic dbt tests to validate primary keys/uniqueness in my model
  • I have updated dbt docs by running dbt docs generate and copying the appropriate files to the docs/ path
  • I have added at least one Github label to this PR

(Optional) Gif of how this PR makes you feel

Loom link

https://www.loom.com/share/811aea02f6764aa9985f398c2ad91f6d

For reviewers

Best practices for reviewing pull requests.

@sarah-tuva sarah-tuva added the bug Something isn't working label Dec 5, 2022
Copy link
Member

@thutuva thutuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @sarah-tuva!

@sarah-tuva sarah-tuva merged commit 72e735c into main Dec 6, 2022
@sarah-tuva sarah-tuva deleted the eligibility-bug-fix branch December 8, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants