Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimizes keyboard on search screen #4633

Merged

Conversation

andrewhamilton0
Copy link
Contributor

@andrewhamilton0 andrewhamilton0 commented Aug 29, 2024

Adds feature if user clicks on toolbar, on the pages box, or on the tabs buttons that the keyboard will minimize and focus will be taken off of search bar.

Further addresses issue #4573

@connyduck
Copy link
Collaborator

I'm not sure this is necessary

@andrewhamilton0
Copy link
Contributor Author

andrewhamilton0 commented Aug 29, 2024

I'm not sure this is necessary

I noticed that after I performed a search, the text box becomes unfocused as expected. But then I went to edit the search, clicked the text box, and then I decided not to edit it. The only way to get rid of the focus was to perform the search, even if I clicked into pager items and back.

I was confused why it was doing this at first as I thought I fixed the bug but I had forgot I re-clicked on the text box without editing and completing a search.

It's not the biggest deal, but I do find it as a nice feature, but I do understand if you find it unnecessary

@connyduck
Copy link
Collaborator

Ok, I tried it out and I guess it makes sense. But the keyboard should alse be hidden when switching tabs, no?

@andrewhamilton0
Copy link
Contributor Author

Ok, I tried it out and I guess it makes sense. But the keyboard should alse be hidden when switching tabs, no?

Yes you're right! I went ahead and added that functionality as well!

@connyduck connyduck merged commit 49fbe1f into tuskyapp:develop Sep 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants