Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Greetings.yml added #34

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

praptisharma28
Copy link
Contributor

closes #33

@tushar5526
Copy link
Owner

@praptisharma28 you will have to install pre-commit pip install pre-commit and pre-commit install and then run pre-commit on all files to fix the error. pre-commit run --all-files

@praptisharma28
Copy link
Contributor Author

Added precomit in the environment variables , still its not recognised ? @tushar5526

@tushar5526
Copy link
Owner

https://pre-commit.com/ - Setup this

@praptisharma28
Copy link
Contributor Author

done @tushar5526

requirements.txt Outdated
filelock==3.13.1
pre-commit
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit will rather go in requirements-dev.txt as it is a dev requirement not a core requirement.

Copy link
Owner

@tushar5526 tushar5526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move pre-commit to dev requirements.

@praptisharma28
Copy link
Contributor Author

ok done @tushar5526 , dev already have a version of pre-commit. removed from requirements.txt . You can check now.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (301f690) 87.31% compared to head (e4274fb) 87.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files           3        3           
  Lines         276      276           
=======================================
  Hits          241      241           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@praptisharma28
Copy link
Contributor Author

@tushar5526 do I need to do anything more?

@tushar5526 tushar5526 merged commit 8d933a4 into tushar5526:main Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add the github action workflow for greeting contributors
2 participants