Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add main unit tests for compose helper util #12

Merged
merged 6 commits into from
Jan 15, 2024
Merged

feat: add main unit tests for compose helper util #12

merged 6 commits into from
Jan 15, 2024

Conversation

tushar5526
Copy link
Owner

Related to #4

jatinkrmalik
jatinkrmalik suggested changes Jan 8, 2024
View reviewed changes
Copy link

@jatinkrmalik jatinkrmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have suggested some enhancements! Most of the code is good, but we can work on nit to improve readability and maintanability! :)

server/utils.py Outdated Show resolved Hide resolved
server/utils.py Show resolved Hide resolved
tests/test_utils.py Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@tushar5526
Copy link
Owner Author

Thanks for the review @jatinkrmalik I will make the changes soon!

@tushar5526 tushar5526 merged commit 57d6910 into main Jan 15, 2024
2 checks passed
@tushar5526 tushar5526 deleted the tests branch January 15, 2024 20:32
@tushar5526 tushar5526 mentioned this pull request Jan 18, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatinkrmalik jatinkrmalik jatinkrmalik requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tushar5526 @jatinkrmalik