Python3 patches #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is incomplete, however it's also API compatible. Should be sufficient for the time being.
See https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments for why this is dangerous and likely has (or will) cause confusion to users. I've attempted to do my best to make this a non-breaking changes, however I can't guarantee some exceptionally abnormal use-cases will not be broken by this.
I can only assume the `\?` as intended as a regex escape rather than a python character escape
|
Great work! I'm going to merge this! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of API compatible patches built on top of #8
@JedMeister up to you on how you want to merge this. This does not contain the rebased changes from the other out-standing PRs.