Preserve newlines in plain text messages #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8148c3f
to
bfc7dd5
Compare
tulir
reviewed
Oct 18, 2022
ui/messages/html/parser.go
Outdated
| @@ -388,16 +388,39 @@ func (parser *htmlParser) tagNodeToEntity(node *html.Node) Entity { | |||
|
|
|||
| var spaces = regexp.MustCompile("\\s+") | |||
|
|
|||
| // textToHtmlEntity converts a plain text string into an HtmlEntity while preserving newlines. | |||
| func textToHtmlEntity(text string) Entity { | |||
There was a problem hiding this comment.
HTML should be uppercase (https://github.com/golang/go/wiki/CodeReviewComments#initialisms)
tulir
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New lines were not displayed in plain text messages. There might be a better way, but I choose to manually convert the newline characters into BreakEntities inside of a ContainerEntity.
I didn't use my new function for the value of a plan text link, as it must not contain any new lines.
Demo
Event
{ "room_id": "!***:matrix.org", "type": "m.room.message", "content": { "org.matrix.msc1767.text": "Probablement que j'ai pas répondu alors 😅\nMerci pour le partage mais je suis pas chaud pour y aller", "body": "Probablement que j'ai pas répondu alors 😅\nMerci pour le partage mais je suis pas chaud pour y aller", "msgtype": "m.text" } }Before
After