Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment to reflect productNameWithExtension() and others #823

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Update comment to reflect productNameWithExtension() and others #823

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ee81b
fix(820): Update comment to reflect productNameWithExtension() and ot…
mikeger May 28, 2024
c3277f4
Update Sources/XcodeProj/Objects/Targets/PBXTarget.swift
mikeger May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/XcodeProj/Objects/Targets/PBXTarget.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
public var name: String

/// Target product name.
///
/// This property's value may differ from the value displayed in Xcode if the product name is specified through build settings.
public var productName: String?

/// Target product reference.
Expand All @@ -78,7 +80,7 @@

/// Swift packages products.
public var packageProductDependencies: [XCSwiftPackageProductDependency] {
set {

Check warning on line 83 in Sources/XcodeProj/Objects/Targets/PBXTarget.swift

View workflow job for this annotation

GitHub Actions / Swiftlint 

Computed Accessors Order Violation: Computed properties should first declare the getter and then the setter (computed_accessors_order)
packageProductDependencyReferences = newValue.references()
}
get {
Expand Down Expand Up @@ -219,6 +221,8 @@
public extension PBXTarget {
/// Returns the product name with the extension joined with a period.
///
/// This property's value may differ from the value displayed in Xcode if the product name is specified through build settings.
///
/// - Returns: product name with extension.
func productNameWithExtension() -> String? {
guard let productName = self.productName else { return nil }
Expand Down
Loading