docs: Add try-catch to getting started #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwridan
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Thanks for contributing this @AlexKobachiJP
Agreed, making the docs closer to reality is needed. At the very least try ... incase someone does copy and paste the snippet. 👍
|
@all-contributors add @AlexKobachiJP for docs |
|
I've put up a pull request to add @AlexKobachiJP! 🎉 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this was left out on purpose to keep the sample as small as possible but I feel that a getting started document should show code that builds without requiring fixes, even if it is as simple as adding a
trystatement, because it otherwise makes the documentation look sloppy.(Apologies for not creating an issue first.)