Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hashable for XCScheme.BuildableReference #712

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Implement Hashable for XCScheme.BuildableReference #712

merged 1 commit into from
Aug 12, 2022

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented Aug 9, 2022

Short description πŸ“

Allow XCScheme.BuildableReference to be used with Set and as a key for Dictionary.

Solution πŸ“¦

Implement Hashable.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Implemented Hashable.
  • Added test to ensure that Hashable contract is maintained.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @cgrindel

@kwridan
Copy link
Collaborator

kwridan commented Aug 10, 2022

@all-contributors add @cgrindel for code

@allcontributors
Copy link
Contributor

@kwridan

I've put up a pull request to add @cgrindel! πŸŽ‰

@cgrindel
Copy link
Contributor Author

It looks like the macOS 12.4 test is failing but the failing test does not appear to be related to my change. Are these known flaky tests? If so, could someone with permission re-run the failed jobs?

@brentleyjones
Copy link
Contributor

Yes. #715 will make the 12.4 ones not fail.

@cgrindel
Copy link
Contributor Author

I just rebased with the fix for #715. When someone gets a chance, could they approve the workflow? Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #712 (1be1772) into main (3e3a216) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   84.80%   84.83%   +0.03%     
==========================================
  Files         157      158       +1     
  Lines        9179     9201      +22     
==========================================
+ Hits         7784     7806      +22     
  Misses       1395     1395              
Impacted Files Coverage Ξ”
...XcodeProj/Scheme/XCScheme+BuildableReference.swift 81.03% <100.00%> (+1.78%) ⬆️
...ests/Scheme/XCScheme+BuildableReferenceTests.swift 100.00% <100.00%> (ΓΈ)

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luispadron luispadron merged commit e6497b2 into tuist:main Aug 12, 2022
@cgrindel cgrindel deleted the add_hashable_to_buildable_reference branch August 12, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants