Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disablePerformanceAntipatternChecker to scheme #694

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Add disablePerformanceAntipatternChecker to scheme #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d65c072
Add disablePerformanceAntipatternChecker to LaunchAction
Bogdan-Belogurov Jun 29, 2022
362b3fa
Cover with tests disablePerformanceAntipatternChecker action
Bogdan-Belogurov Jun 29, 2022
42f3367
Update CHANGELOG.md
Bogdan-Belogurov Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Next

### Added

- Added `disablePerformanceAntipatternChecker` to `XCScheme` [#693](https://github.com/tuist/XcodeProj/pull/603) by [@Bogdan-Belogurov](https://github.com/Bogdan-Belogurov)

## 8.7.1

### Changed
Expand Down
8 changes: 8 additions & 0 deletions Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ extension XCScheme {
public var enableUBSanitizer: Bool
public var stopOnEveryUBSanitizerIssue: Bool
public var disableMainThreadChecker: Bool
public var disablePerformanceAntipatternChecker: Bool
public var stopOnEveryMainThreadCheckerIssue: Bool
public var additionalOptions: [AdditionalOption]
public var commandlineArguments: CommandLineArguments?
Expand Down Expand Up @@ -96,6 +97,7 @@ extension XCScheme {
enableUBSanitizer: Bool = false,
stopOnEveryUBSanitizerIssue: Bool = false,
disableMainThreadChecker: Bool = false,
disablePerformanceAntipatternChecker: Bool = false,
stopOnEveryMainThreadCheckerIssue: Bool = false,
additionalOptions: [AdditionalOption] = [],
commandlineArguments: CommandLineArguments? = nil,
Expand Down Expand Up @@ -129,6 +131,7 @@ extension XCScheme {
self.enableUBSanitizer = enableUBSanitizer
self.stopOnEveryUBSanitizerIssue = stopOnEveryUBSanitizerIssue
self.disableMainThreadChecker = disableMainThreadChecker
self.disablePerformanceAntipatternChecker = disablePerformanceAntipatternChecker
self.stopOnEveryMainThreadCheckerIssue = stopOnEveryMainThreadCheckerIssue
self.additionalOptions = additionalOptions
self.commandlineArguments = commandlineArguments
Expand Down Expand Up @@ -191,6 +194,7 @@ extension XCScheme {
enableUBSanitizer = element.attributes["enableUBSanitizer"] == "YES"
stopOnEveryUBSanitizerIssue = element.attributes["stopOnEveryUBSanitizerIssue"] == "YES"
disableMainThreadChecker = element.attributes["disableMainThreadChecker"] == "YES"
disablePerformanceAntipatternChecker = element.attributes["disablePerformanceAntipatternChecker"] == "YES"
stopOnEveryMainThreadCheckerIssue = element.attributes["stopOnEveryMainThreadCheckerIssue"] == "YES"

additionalOptions = try element["AdditionalOptions"]["AdditionalOption"]
Expand Down Expand Up @@ -267,6 +271,9 @@ extension XCScheme {
if disableMainThreadChecker {
attributes["disableMainThreadChecker"] = disableMainThreadChecker.xmlString
}
if disablePerformanceAntipatternChecker {
attributes["disablePerformanceAntipatternChecker"] = disablePerformanceAntipatternChecker.xmlString
}
if stopOnEveryMainThreadCheckerIssue {
attributes["stopOnEveryMainThreadCheckerIssue"] = stopOnEveryMainThreadCheckerIssue.xmlString
}
Expand Down Expand Up @@ -365,6 +372,7 @@ extension XCScheme {
enableUBSanitizer == rhs.enableUBSanitizer &&
stopOnEveryUBSanitizerIssue == rhs.stopOnEveryUBSanitizerIssue &&
disableMainThreadChecker == rhs.disableMainThreadChecker &&
disablePerformanceAntipatternChecker == rhs.disablePerformanceAntipatternChecker &&
stopOnEveryMainThreadCheckerIssue == rhs.stopOnEveryMainThreadCheckerIssue &&
additionalOptions == rhs.additionalOptions &&
commandlineArguments == rhs.commandlineArguments &&
Expand Down
3 changes: 3 additions & 0 deletions Tests/XcodeProjTests/Scheme/XCSchemeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ final class XCSchemeIntegrationTests: XCTestCase {
XCTAssertEqual(scheme.launchAction?.enableUBSanitizer, false)
XCTAssertEqual(scheme.launchAction?.stopOnEveryUBSanitizerIssue, false)
XCTAssertEqual(scheme.launchAction?.disableMainThreadChecker, false)
XCTAssertEqual(scheme.launchAction?.disablePerformanceAntipatternChecker, false)
XCTAssertEqual(scheme.launchAction?.stopOnEveryMainThreadCheckerIssue, false)
XCTAssertEqual(scheme.launchAction?.additionalOptions.isEmpty, true)

Expand Down Expand Up @@ -544,6 +545,7 @@ final class XCSchemeIntegrationTests: XCTestCase {
XCTAssertEqual(scheme.launchAction?.enableUBSanitizer, false)
XCTAssertEqual(scheme.launchAction?.stopOnEveryUBSanitizerIssue, false)
XCTAssertEqual(scheme.launchAction?.disableMainThreadChecker, false)
XCTAssertEqual(scheme.launchAction?.disablePerformanceAntipatternChecker, false)
XCTAssertEqual(scheme.launchAction?.stopOnEveryMainThreadCheckerIssue, false)
XCTAssertEqual(scheme.launchAction?.additionalOptions.isEmpty, true)
XCTAssertNil(scheme.launchAction?.storeKitConfigurationFileReference)
Expand Down Expand Up @@ -636,6 +638,7 @@ final class XCSchemeIntegrationTests: XCTestCase {
XCTAssertEqual(scheme.launchAction?.enableUBSanitizer, false)
XCTAssertEqual(scheme.launchAction?.stopOnEveryUBSanitizerIssue, false)
XCTAssertEqual(scheme.launchAction?.disableMainThreadChecker, false)
XCTAssertEqual(scheme.launchAction?.disablePerformanceAntipatternChecker, false)
XCTAssertEqual(scheme.launchAction?.stopOnEveryMainThreadCheckerIssue, false)
XCTAssertEqual(scheme.launchAction?.additionalOptions.isEmpty, true)
XCTAssertNil(scheme.launchAction?.storeKitConfigurationFileReference)
Expand Down