Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct LaunchAction scheme order #686

Merged

Conversation

maxwellE
Copy link
Contributor

@maxwellE maxwellE commented Jun 2, 2022

Short description 馃摑

Adds logic and tests to ensure that the XML
ordering for LaunchAction schemes matches what
xcode expects

Adds logic and tests to ensure that the XML
ordering for `LaunchAction` matches what
xcode expects
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #686 (49d4820) into main (65ca255) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   84.84%   84.89%   +0.05%     
==========================================
  Files         157      157              
  Lines        9044     9076      +32     
==========================================
+ Hits         7673     7705      +32     
  Misses       1371     1371              
Impacted Files Coverage 螖
...urces/XcodeProj/Extensions/AEXML+XcodeFormat.swift 92.45% <酶> (酶)
...eProjTests/Extensions/AEXML+XcodeFormatTests.swift 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 65ca255...49d4820. Read the comment docs.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxwellE

@maxwellE
Copy link
Contributor Author

maxwellE commented Jun 3, 2022

@pepicrft Can I get a review on this? Thanks

@danieleformichelli danieleformichelli merged commit 651cbda into tuist:main Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants