Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docc file type support #660

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

Jake-Prickett
Copy link
Contributor

@Jake-Prickett Jake-Prickett commented Dec 15, 2021

Resolves tuist/tuist#3650

Short description πŸ“

Adds support for including Docs.docc files.

Solution πŸ“¦

Inspected the project file to determine fileType for the new extension.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

Add docc and file type to Xcode constants for the project.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #660 (4b69815) into main (8998757) will increase coverage by 0.08%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
+ Coverage   84.66%   84.75%   +0.08%     
==========================================
  Files         154      157       +3     
  Lines        8878     8987     +109     
==========================================
+ Hits         7517     7617     +100     
- Misses       1361     1370       +9     
Impacted Files Coverage Ξ”
Sources/XcodeProj/Project/Xcode.swift 100.00% <ΓΈ> (ΓΈ)
...ests/Objects/Project/PBXProjIntegrationTests.swift 100.00% <ΓΈ> (+1.29%) ⬆️
.../XcodeProj/Scheme/XCScheme+TestableReference.swift 72.88% <62.50%> (-1.63%) ⬇️
Sources/XcodeProj/Scheme/XCSchemeManagement.swift 87.69% <87.69%> (ΓΈ)
...s/XcodeProjTests/Extensions/XCTestCase+Shell.swift 92.85% <92.85%> (ΓΈ)
...codeProjTests/Scheme/XCSchemeManagementTests.swift 100.00% <100.00%> (ΓΈ)
Sources/XcodeProj/Utils/JSONDecoding.swift 72.58% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 5fd7622...4b69815. Read the comment docs.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @Jake-Prickett

@pepicrft
Copy link
Contributor

@all-contributors add @Jake-Prickett for code

@allcontributors
Copy link
Contributor

@pepicrft

I've put up a pull request to add @Jake-Prickett! πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docc Support
4 participants