Make runPostActionsOnFailure optional
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: tuist/tuist#2991 - Generated projects had `runPostActionsOnFailure` set in their schemes by default to `NO` - Xcode ends up removing this attribute when it's value is `NO` resultting in producing git diffs for any checked in projects that were previously generated - To mitigate this, the `runPostActionsOnFailure` option is being changed to an optional one where it's only written in the case it's explicitly defined to a specific value Test Plan: - Verify unit tests pass
Codecov Report
@@ Coverage Diff @@
## main #619 +/- ##
==========================================
+ Coverage 84.17% 84.32% +0.15%
==========================================
Files 154 154
Lines 8718 8738 +20
==========================================
+ Hits 7338 7368 +30
+ Misses 1380 1370 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: tuist/tuist#2991
Short description 📝
runPostActionsOnFailureset in their schemes by default toNONOresultting in producing git diffs for any checked in projects that were previously generatedSolution 📦
To mitigate this, the
runPostActionsOnFailureoption is being changed to an optional one where it's only written in the case it's explicitly defined to a specific valueImplementation 👩💻👨💻
runPostActionsOnFailureas optional