Add inline comments support to the xcconfig
parser
#604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #602
Short description 📝
Add support for inline comments in
xcconfig
files.Solution 📦
Extend the existed regular expression to support
xcconfig
comments and use them as a full-stop condition.Implementation 👩💻👨💻
XCConfig.swift
regular expression (settingRegex
) extended with a positive lookahead condition as the last statement. Previously, the expression handles the end of the line ('$') as a final grouping statement and now it parses up until the end of the line or up to the comment indication (//
) with the(?=$|\\/\\/)
group.XCConfigTests
with failing scenariossettingRegex
NSRegularExpression
to support commentsXCConfigTests
with edge-casesP.S. You can play with the updated regular expression here.