Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runPostActionsOnFailure to scheme #603

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

FranzBusch
Copy link
Contributor

Short description 📝

Schemes have an additional option to run post actions even on failure modes. This is particularly useful when you want to run a script to track something like the build time after any build concluded.

Solution 📦

I added a new attribute to the scheme runPostActionsOnFailure similar to the already existing buildImplicitDependencies attribute.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #603 (fc09c73) into main (c8afc79) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   84.25%   84.24%   -0.01%     
==========================================
  Files         154      154              
  Lines        8674     8682       +8     
==========================================
+ Hits         7308     7314       +6     
- Misses       1366     1368       +2     
Impacted Files Coverage Δ
...urces/XcodeProj/Extensions/AEXML+XcodeFormat.swift 92.45% <ø> (ø)
...ources/XcodeProj/Scheme/XCScheme+BuildAction.swift 66.19% <33.33%> (-0.97%) ⬇️
...eProjTests/Extensions/AEXML+XcodeFormatTests.swift 100.00% <100.00%> (ø)
Tests/XcodeProjTests/Scheme/XCSchemeTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8afc79...fc09c73. Read the comment docs.

@FranzBusch
Copy link
Contributor Author

@pepibumur Would it be possible for you to take a look here?

Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @FranzBusch, thanks for adding it. Would you mind updating the changelog? After that we can merge and release a new version of XcodeProj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants