Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podspec: add module_name #578

Merged
merged 1 commit into from
Oct 27, 2020
Merged

podspec: add module_name #578

merged 1 commit into from
Oct 27, 2020

Conversation

dflems
Copy link
Contributor

@dflems dflems commented Oct 26, 2020

The package was renamed to XcodeProj from xcodeproj in #398 but this change was not applied to the podspec. Seems like module_name is the best fit for this.

@pepibumur

@dflems dflems requested a review from pepicrft October 26, 2020 17:37
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #578 into master will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   83.43%   84.24%   +0.81%     
==========================================
  Files         159      153       -6     
  Lines        8770     8525     -245     
==========================================
- Hits         7317     7182     -135     
+ Misses       1453     1343     -110     
Impacted Files Coverage Δ
...build/checkouts/AEXML/Sources/AEXML/Document.swift
.build/checkouts/AEXML/Sources/AEXML/Parser.swift
.build/checkouts/AEXML/Sources/AEXML/Element.swift
...s/XcodeProjCExt/Sources/XcodeProjCExt/XCPHashing.c
...deProjCExt/Sources/XcodeProjCExt/XCPStringEscape.c
.build/checkouts/AEXML/Sources/AEXML/Options.swift

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3038221...5d487c4. Read the comment docs.

@pepicrft pepicrft merged commit af9080c into master Oct 27, 2020
@pepicrft pepicrft deleted the dflems-patch-1 branch October 27, 2020 07:04
@pepicrft
Copy link
Contributor

It's released in 7.16.0

@pepicrft
Copy link
Contributor

@all-contributors add @dflems for code

@allcontributors
Copy link
Contributor

@pepibumur

I've put up a pull request to add @dflems! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants