Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PBXBuildPhase.type() function #571

Merged

Conversation

marciniwanicki
Copy link
Collaborator

Resolves #512

Deprecate func type() -> BuildPhase? of PBXBuildPhase. The method is redundant and might be removed in the future as the underlying buildPhase property is public.

@pepicrft pepicrft changed the base branch from master to main October 28, 2020 07:59
@pepicrft pepicrft merged commit cf15463 into tuist:main Oct 28, 2020
pepicrft pushed a commit that referenced this pull request Oct 28, 2020
* Deprecate PBXBuildPhase.type() function

* Update CHANGELOG

Co-authored-by: Marcin Iwanicki <[email protected]>
Co-authored-by: Pedro Piñera Buendía <[email protected]>
@pepicrft
Copy link
Contributor

@all-contributors add @marciniwanicki for maintenance

@allcontributors
Copy link
Contributor

@pepibumur

I've put up a pull request to add @marciniwanicki! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBXBuildPhase type redudancy
2 participants