.bundle explicitFileType corrected

[adamkhazi]

Resolves #562

Short description 📝

Adding a bundle in Xcode 12 Beta 2 and Xcode 11.5 will add a .bundle reference under the Products folder. This reference in the .pbxproj will have explicitFileType = wrapper.cfbundle. Tuist will use Xcode.swift and set the value of explicitFileType to the wrong value.

Solution 📦

Correct the value for "bundle" in Xcode.swift to use wrapper.cfbundle which mimics the behaviour of Xcode 12 Beta 2 and Xcode 11.5.

[pepicrft]

Hey @adamkhazi. Thanks for adding this to the project. Since this is a breaking change, I'm thinking we could extend the fileType to support passing the Xcode version being used:

filetype(extension: String, xcodeVerison: Version) -> String?

That way, consumers of the library could get the right extension for the version of Xcode they are using xcodeproj with. If don't do this we'll have to mark this change as breaking, and release a major version of the library.

[adamkhazi]

Hey @pepibumur could I get some clarification as to why this is a breaking change? I am happy to make the changes you suggested.

[pepicrft]

Hey @pepibumur could I get some clarification as to why this is a breaking change? I am happy to make the changes you suggested.

Sure, if I'm not wrong, the explicitFileType for bundles has changed in Xcode 12. If we merge this change, and someone uses the latest version of the library to lets say, generate projects, the generated projects might not be compatible with Xcode 11 because bundles will have the explicitFileType that Xcode 12 expects.

Correct me if I'm wrong, I might be missing some details.

[adamkhazi]

Thanks for the reply @pepibumur

The .bundle references in the .pbxproj from Xcode 11.1, 11.5, 12 Beta 2, 12 Beta 3 in my tests have had explicitFileType = wrapper.cfbundle when I added a bundle manually through the Xcode UI.

I also tested adding a bundle in Xcode 12 Beta 3 and opening it in Xcode 11.5 and saw no problems.

[pepicrft]

In that case it seems all good. Let's merge the PR :)

[pepicrft]

@all-contributors add @adamkhazi for maintenance

[allcontributors]

@pepibumur

I've put up a pull request to add @adamkhazi! 🎉