System library added to a group has empty path

[damirdavletov]

Short description 📝

Adding system library to Frameworks group using PBXGroup.addFile() method causes BPFFileReference to have empty path

Solution 📦

Edit PBXGroup.addFile method to correctly create a file with path that was passed with sourceTree type sdkRoot and developerDir

[damirdavletov]

Thanks for the quick review @pepibumur ! I've updated the changelog as well.

[pepicrft]

Thank you for fixing it! We can merge it as soon as CI is happy.

[codecov]

Codecov Report

Merging #488 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage    82.4%   82.53%   +0.13%     
==========================================
  Files         148      148              
  Lines        8052     8073      +21     
==========================================
+ Hits         6635     6663      +28     
+ Misses       1417     1410       -7

Impacted Files	Coverage Δ
Sources/XcodeProj/Objects/Files/PBXGroup.swift	79.04% <100%> (+1.37%)	⬆️
...s/XcodeProjTests/Objects/Files/PBXGroupTests.swift	94.08% <100%> (+0.74%)	⬆️
Sources/XcodeProj/Objects/Targets/PBXTarget.swift	83.33% <0%> (+4.76%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea74aaf...d27b344. Read the comment docs.