Add remote Swift packages to the Frameworks build phase #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There was a typo in one of the helper methods that adds remote Swift packages that led to products being added to the sources build phase rather than the frameworks build phase Test Plan: - Update tuist/tuist to point to this branch of XcodeProj - Run `tuist generate` within `fixtures/ios_app_with_remote_swift_package` - Verify the remote packages do not appear within the sources build phase
fortmarek
approved these changes
Oct 8, 2019
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=========================================
- Coverage 82.47% 82.4% -0.08%
=========================================
Files 148 148
Lines 8052 8052
=========================================
- Hits 6641 6635 -6
- Misses 1411 1417 +6
Continue to review full report at Codecov.
|
damirdavletov
added a commit
to badoo/xcodeproj
that referenced
this pull request
Mar 13, 2020
…clab_dev * 'master' of https://github.com/badoo/xcodeproj: Updated changelog Tests for adding system library to group Add remote Swift packages to the Frameworks build phase (tuist#487) Bump cocoapods from 1.8.1 to 1.8.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
tuist generatewithinfixtures/ios_app_with_remote_swift_package