Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock #449

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Fix deadlock #449

merged 2 commits into from
Jun 20, 2019

Conversation

pepicrft
Copy link
Contributor

Resolves #446

Short description 📝

The delete from PBXObjects, does not use the lock properly and as a consequence, we end up with a dead lock.

Solution 📦

Add a defer block to unlock the lock.

@pepicrft pepicrft requested a review from a team June 20, 2019 19:16
@pepicrft pepicrft self-assigned this Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #449 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   80.42%   80.43%   +0.01%     
==========================================
  Files         149      149              
  Lines        7652     7652              
==========================================
+ Hits         6154     6155       +1     
+ Misses       1498     1497       -1
Impacted Files Coverage Δ
Sources/xcodeproj/Objects/Project/PBXObjects.swift 73.28% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00885b1...870e836. Read the comment docs.

@pepicrft pepicrft merged commit aa14558 into master Jun 20, 2019
@pepicrft pepicrft deleted the fix-deadlock branch June 20, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead lock when PBXObjects.delete
1 participant