Make PBXObjectReference internal #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Danger run resulted in 1 message and 1 warning; to find out more, see the checks page. Generated by 🚫 dangerJS |
|
Danger run resulted in 1 warning; to find out more, see the checks page. Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #293
Short description 📝
With this change,
PBXObjectReferencebecomes an implementation detail that consumers of the API don't need to know about. The relationships are now defined through objects.Solution 📦
PBXObjectReferenceinternal.PBXObjectReferenceinternal.PBXObjectReference.PBXObjectsthose attributes and methods have been moved to thePBXProj, keepingPBXObjectsas an internal object. This allows us making changes at that level without affecting the public API.