-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform Equatable from XCScheme types #273
Conversation
Danger run resulted in 2 messages; to find out more, see the checks page. Generated by 🚫 dangerJS |
Generated by 🚫 Danger |
@@ -0,0 +1,42 @@ | |||
import AEXML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also potentially put these files in an XCScheme
group and drop the XCScheme+
from the filename. It would clean up the list of files a bit as there are so many now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
// MARK: - Equatable | ||
|
||
public static func == (lhs: BuildableProductRunnable, rhs: BuildableProductRunnable) -> Bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason these aren't using Sourcery
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work well with nested types.
a82242f
to
c9aea44
Compare
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=========================================
- Coverage 71.4% 69.7% -1.71%
=========================================
Files 100 116 +16
Lines 5029 5152 +123
=========================================
Hits 3591 3591
- Misses 1438 1561 +123
Continue to review full report at Codecov.
|
Short description 📝
XCScheme types don't conform the equatable protocol. This PR aims to add conformance to all the scheme-related types in the project.