Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform Equatable from XCScheme types #273

Merged
merged 9 commits into from
Aug 8, 2018
Merged

Conform Equatable from XCScheme types #273

merged 9 commits into from
Aug 8, 2018

Conversation

pepicrft
Copy link
Contributor

Short description 📝

XCScheme types don't conform the equatable protocol. This PR aims to add conformance to all the scheme-related types in the project.

@ghost
Copy link

ghost commented Jun 20, 2018

Danger run resulted in 2 messages; to find out more, see the checks page.

Generated by 🚫 dangerJS

@tuistbot
Copy link

tuistbot commented Jun 20, 2018

1 Warning
⚠️ PR is classed as Work in Progress

Generated by 🚫 Danger

@@ -0,0 +1,42 @@
import AEXML
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also potentially put these files in an XCScheme group and drop the XCScheme+ from the filename. It would clean up the list of files a bit as there are so many now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


// MARK: - Equatable

public static func == (lhs: BuildableProductRunnable, rhs: BuildableProductRunnable) -> Bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason these aren't using Sourcery?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work well with nested types.

@pepicrft pepicrft changed the title [WIP] Conform Equatable from XCScheme types Conform Equatable from XCScheme types Aug 8, 2018
@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #273 into master will decrease coverage by 1.7%.
The diff coverage is 55.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #273      +/-   ##
=========================================
- Coverage    71.4%   69.7%   -1.71%     
=========================================
  Files         100     116      +16     
  Lines        5029    5152     +123     
=========================================
  Hits         3591    3591              
- Misses       1438    1561     +123
Impacted Files Coverage Δ
...deprojTests/Objects/PBXSourcesBuildPhaseSpec.swift 100% <ø> (ø)
Sources/xcodeproj/Errors/Errors.swift 6.89% <ø> (ø)
Tests/xcodeprojTests/Utils/XCConfigSpec.swift 97.43% <ø> (ø)
Tests/xcodeprojTests/Objects/PBXProjSpec.swift 90.16% <ø> (ø)
Sources/xcodeproj/Project/XcodeProj.swift 0% <ø> (ø)
Sources/xcodeproj/Extensions/Bool+Extras.swift 100% <ø> (ø)
Sources/xcodeproj/Objects/PBXProject.swift 80.19% <ø> (ø)
...Workspace/XCWorkspaceDataElementLocationType.swift 79.36% <ø> (ø)
...rces/xcodeproj/Objects/PBXContainerItemProxy.swift 94.11% <ø> (ø)
Tests/xcodeprojTests/Objects/BuildPhaseSpecs.swift 100% <ø> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd370fc...2dc4574. Read the comment docs.

@pepicrft pepicrft merged commit f536e1f into master Aug 8, 2018
@pepicrft pepicrft deleted the equatable-review branch August 8, 2018 23:47
@pepicrft pepicrft mentioned this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants