Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 4.1 #249

Merged
merged 22 commits into from
Apr 5, 2018
Merged

Update to Swift 4.1 #249

merged 22 commits into from
Apr 5, 2018

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Apr 5, 2018

Short description 📝

This PRs updates dependencies and migrates the project to Swift 4.1

Solution 📦

A bunch of syntax updates, dependencies bumps, and some issues fixed.

@pepicrft pepicrft requested review from esttorhe and a team April 5, 2018 14:39
Rakefile Outdated
def osx
if ENV["TRAVIS_OS_NAME"] == "linux"
return :linux
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not check if os name is osx like in .travis.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea @allu22. I've updated it.

@tuist tuist deleted a comment from tuistbot Apr 5, 2018
@tuist tuist deleted a comment from tuistbot Apr 5, 2018
@pepicrft pepicrft changed the title Update travis pipeline to run on Linux Update to Swift 4.1 Apr 5, 2018
@pepicrft
Copy link
Contributor Author

pepicrft commented Apr 5, 2018

I'll bump the Swift version on this PR and open another one for running the CI pipeline on Linux. It turns out there's some work to be done to support linux.

@pepicrft pepicrft merged commit 0d33e05 into master Apr 5, 2018
@pepicrft pepicrft deleted the linux branch April 5, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants