Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
PBXObject
no longer contains a reference, the helper methods that return a PBXObject are hard to work with as you don't know the reference, for exampletargets(named: String) -> PBXTarget
This can also be evidenced by the new helper functions in #213 that all return a tuple of the reference and the object.
This PR adds a new genenric type
ObjectReference
that contains the reference and the object. This is also used in XcodeGen to ease the migration to the removal of reference from PBXObjectThis is actually a breaking change. I was hoping to get this into 3.0 but I didn't know it was releasing early.
Another addition to the
Objects
class that could have also helped is the addition of agetReference(object: PBXObject) -> String
that would return the reference for a given object using equatable or class identity, but I thought this would be a cleaner approachThis PR also makes
PBXObject
EquatableThis change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)