Danger plugin that checks whether the Carthage project has been generated when needed #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 13, 2017 15:22
…t has been generated after files have been added or deleted from the Sources/xcproj folder
db134b7
to
a907843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182
Short description 📝
When files are added/removed from the
Sources/xcprojfolder theCarthageproject needs to be generated. Contributors were not aware of that and they had to wait until the build finished to see the compilation error on Travis-CI.Solution 📦
This PR adds a Danger plugin that makes the build fail earlier if files have been added/removed without regenerating the Carthage project.
Implementation 👩💻👨💻
citask to run the rspec tests as wellGIF
This change is