Use productRefGroup name as CommentedString comment #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds test to check of productRefGroup name is used as comment during serialisation. Adds fixture project to check if project without products group is written correctly.
a52738b
to
6c394d6
Compare
pepicrft
approved these changes
Nov 20, 2017
|
It's ready to be merged @allu22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
At the moment
productRefGroupcomment is alwaysProducts. It probably covers 99.99% of use cases. But the comment should actually be a name of that group.It will cause problems when you change the name of that group or don't have dedicated products group at all (In that case it falls back to main group).
Solution 📦
Use productRefGroup name as CommentedString comment.
GIF