Fix decoding fileEncoding #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the old-style plist format that's used for .pbxproj files seems to encode only Strings (and Arrays and Dictionaries) and does not preserve number types, we have to decode fileEncoding to a String first.
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
pepicrft
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the old-style plist format that's used for .pbxproj files seems to encode only Strings (and Arrays and Dictionaries) and does not preserve number types, we have to decode fileEncoding to
a String first.
For most projects where files are UTF-8 encoded the corresponding
fileEncoding = 4is omitted.Thus this bug wouldn't manifest with many regular and recent projects.
In certain cases (like using the search & replace preview from Xcode 8 and prior) Xcode did add
fileEncoding = 4explicitly. I had some .pbxproj files around where this was the case and there the decoding failed.