Support SPM generated projects #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemnovichkov
suggested changes
Oct 19, 2017
Sources/xcproj/XCWorkspace.swift
Outdated
| @@ -34,6 +34,12 @@ public class XCWorkspace { | |||
| self.data = data | |||
| } | |||
|
|
|||
| /// Returns an empty workspace. | |||
| public static var `empty`: XCWorkspace { | |||
| let data = XCWorkspace.Data(references: []) | |||
There was a problem hiding this comment.
Is it possible to omit XCWorkspace. and use only Data(references: [])?
| return fixturesPath() + "iOS/Project.xcodeproj" | ||
|
|
||
| func test_init_usesAnEmptyWorkspace_whenItsMissing() { | ||
| let got = projectWithoutWorkspace() |
There was a problem hiding this comment.
Why did you use this name?
There was a problem hiding this comment.
It's a project that doesn't have a workspace internally. Would you use a different name @artemnovichkov?
yonaskolb
reviewed
Oct 19, 2017
Sources/xcproj/XCWorkspace.swift
Outdated
| @@ -34,6 +34,12 @@ public class XCWorkspace { | |||
| self.data = data | |||
| } | |||
|
|
|||
| /// Returns an empty workspace. | |||
| public static var `default`: XCWorkspace { | |||
There was a problem hiding this comment.
This makes it seem as if it's a singleton. You could remove this and just make a new initializer that doesn't take data.
There was a problem hiding this comment.
Yeah, makes more sense. Let me update it.
added 4 commits
October 19, 2017 20:17
…ace when it's missing
…implementation to return one file reference, self:
fbdbc82
to
e33b9e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #119
Short description 📝
As @josefdolezal described in the issue above, projects generated by the Swift Package Manager cannot be opened with xcproj because the project.workspace property is non-optional. The purpose of this PR is to provide support for those.
Solution 📦
Since property is public, any change in the property would introduce a breaking change in the API. What I did instead is initializing a workspace with one file reference,
self:in the same way Xcode does.Implementation 👩💻👨💻
XcodeProjectmodel.GIF