Review optionality of attributes #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
esttorhe
approved these changes
Oct 11, 2017
| @@ -14,7 +14,7 @@ public class PBXBuildPhase: PBXObject { | |||
|
|
|||
| public init(reference: String, | |||
| files: [String] = [], | |||
| buildActionMask: UInt = 2147483647, | |||
There was a problem hiding this comment.
Yes!! No more magic ✨ numbers!
983ab18
to
65337f0
Compare
added 15 commits
October 13, 2017 17:23
… be optional, optional
…ties that should be optionals
65337f0
to
8f46723
Compare
yonaskolb
reviewed
Oct 13, 2017
| let proxyTypeString: String = try container.decode(.proxyType) | ||
| self.proxyType = UInt(proxyTypeString).flatMap({ProxyType(rawValue: $0)}) ?? .other | ||
| self.remoteGlobalIDString = try container.decode(.remoteGlobalIDString) | ||
| let proxyTypeString: String? = try container.decodeIfPresent(.proxyType) |
There was a problem hiding this comment.
I noticed when the decoding changes happened there are a whole bunch of these cases where something is decoded into a string and then flatMaped into a UInt. Is there a specific reason for that, as opposed to decoding directly to a UInt?
There was a problem hiding this comment.
Does this not work?
self.proxyType = try container.decodeIfPresent(UInt.self, forKey: .proxyType).flatMap(ProxyType.init) ?? .other
There was a problem hiding this comment.
Yeah the decoder throws because doesn't know how to convert those values into integers @yonaskolb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #101
Short description 📝
Review which attributes should be optional or not.
Solution 📦
For each attribute, I remove it from the object and try to open the project with Xcode. If Xcode can handle not having the value, then the attribute is optional, if the project is considered invalid by Xcode, then the attribute is required.
Implementation
GIF