Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bgw-gui] Added lock() and unlock() to MenuScene #409

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

smilefx
Copy link
Contributor

@smilefx smilefx commented Feb 1, 2024

Additionally fixed lockedProperty not being respected if locking was used in init block.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 14.94%. Comparing base (266db43) to head (98217f1).

Files Patch % Lines
...main/kotlin/tools/aqua/bgw/builder/SceneBuilder.kt 0.00% 13 Missing ⚠️
...w-gui/src/main/kotlin/tools/aqua/bgw/core/Scene.kt 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   14.95%   14.94%   -0.02%     
==========================================
  Files         288      288              
  Lines        7744     7756      +12     
  Branches     1058     1062       +4     
==========================================
+ Hits         1158     1159       +1     
- Misses       6501     6512      +11     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant