Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignalP fails with >10,000 sequences #158

Closed
embatty opened this issue Mar 18, 2016 · 3 comments
Closed

SignalP fails with >10,000 sequences #158

embatty opened this issue Mar 18, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@embatty
Copy link

embatty commented Mar 18, 2016

SignalP has a limit of 10,000 sequences and fails with the error message:
# Sequence limit reached: Max 10000 sequences are allowed

If you give Prokka a sequence with more than 10,000 coding sequences the SignalP step fails silently and it reports 0 signal peptides.

@tseemann
Copy link
Owner

tseemann commented Apr 2, 2016

Clearly your bacterium is too big (or fragmented).
I admit I don't run with signalp much these days.

What behaviour should prokka take if it finda 10,000 genes?
Should it die instead of running signalp?

@tseemann tseemann added the bug label Apr 2, 2016
@tseemann tseemann self-assigned this Apr 2, 2016
@embatty
Copy link
Author

embatty commented Apr 10, 2016

Yes, these are really fragmented assemblies which is why they have a ridiculous number of genes... It would be neat if Prokka caught the SignalP error and gave a warning but continued the run, then I know it failed to run rather than having 0 signal peptides in my genome as a real result.

@tseemann tseemann added this to the Prokka 1.12 milestone Jun 4, 2016
@tseemann
Copy link
Owner

tseemann commented Jun 4, 2016

@embatty I now check if no. seq > 10,000 and don't run signalp in that case. not the best solution but at least doesn't kill your job.

other option is to simply not use --gram option.

@tseemann tseemann closed this as completed Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants