Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-118234 / 22.12 / Nas 118234 - Prevented dialog modal from closing when manual update file is upload #7128

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

Raz-Dva
Copy link
Contributor

@Raz-Dva Raz-Dva commented Sep 26, 2022

Disabled MatDialog closing with download process to prevent update file download from being cancelled.
Check the update process using the "Install Manual Update File".

@Raz-Dva Raz-Dva requested a review from a team as a code owner September 26, 2022 12:26
@Raz-Dva Raz-Dva requested review from undsoft and removed request for a team September 26, 2022 12:26
@bugclerk bugclerk changed the title Nas 118234 - Prevented dialog modal from closing when manual update file is upload NAS-118234 / 22.12 / Nas 118234 - Prevented dialog modal from closing when manual update file is upload Sep 26, 2022
@bugclerk
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #7128 (f2d373f) into master (b956737) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7128   +/-   ##
=======================================
  Coverage   41.81%   41.81%           
=======================================
  Files         991      991           
  Lines       41754    41754           
  Branches     5758     5758           
=======================================
  Hits        17460    17460           
  Misses      24294    24294           
Impacted Files Coverage Δ
...manual-update-form/manual-update-form.component.ts 38.19% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog cannot be closed now.

@Raz-Dva Raz-Dva merged commit 4b8d392 into master Sep 26, 2022
@Raz-Dva Raz-Dva deleted the NAS-118234 branch September 26, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants