Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-118262 / 22.12 / NAS-118262: Improvements for Boot Pool Status page #7122

Merged
merged 5 commits into from
Sep 27, 2022

Conversation

bvasilenko
Copy link
Contributor

Testing

Please test this page System settings > Boot > Boot Pool Status page (/system/boot/status)

@bvasilenko bvasilenko requested a review from a team as a code owner September 23, 2022 05:21
@bvasilenko bvasilenko requested review from denysbutenko and removed request for a team September 23, 2022 05:21
@bugclerk bugclerk changed the title NAS-118262: Improvements for Boot Pool Status page NAS-118262 / 22.12 / NAS-118262: Improvements for Boot Pool Status page Sep 23, 2022
@bugclerk
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #7122 (bc475a4) into master (4990a5a) will increase coverage by 0.02%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #7122      +/-   ##
==========================================
+ Coverage   41.82%   41.84%   +0.02%     
==========================================
  Files         991      991              
  Lines       41757    41798      +41     
  Branches     5758     5768      +10     
==========================================
+ Hits        17463    17490      +27     
- Misses      24294    24308      +14     
Impacted Files Coverage Δ
src/app/interfaces/storage.interface.ts 100.00% <ø> (ø)
...modules/ix-tree/utils/flattern-tree-with-filter.ts 0.00% <0.00%> (ø)
...rd/components/widget-pool/widget-pool.component.ts 0.00% <0.00%> (ø)
...ponents/widget-storage/widget-storage.component.ts 0.00% <0.00%> (ø)
...dataset-management/dataset-management.component.ts 0.00% <0.00%> (ø)
...nents/pools-dashboard/pools-dashboard.component.ts 0.00% <0.00%> (ø)
src/app/pages/system/system.module.ts 0.00% <0.00%> (ø)
src/app/pages/system/system.routing.ts 0.00% <ø> (ø)
...manual-update-form/manual-update-form.component.ts 38.19% <ø> (ø)
...bootenv/bootenv-status/bootenv-status.component.ts 60.22% <45.45%> (+0.47%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bvasilenko bvasilenko merged commit fb63449 into master Sep 27, 2022
@bvasilenko bvasilenko deleted the NAS-118262 branch September 27, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants