NAS-113216 / 22.12 / NAS-113216: Hide 'acltype' and 'aclmode' when creating or editing first level dataset #7098
Conversation
bugclerk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7098 +/- ##
==========================================
+ Coverage 41.15% 41.24% +0.09%
==========================================
Files 1045 1049 +4
Lines 46070 46107 +37
Branches 6393 6405 +12
==========================================
+ Hits 18958 19016 +58
+ Misses 27112 27091 -21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
I think you misunderstood the task.
Root dataset is the first dataset in the hierarchy, it's the one that is created when you add a pool and can only be edited. It is this dataset that shouldn't have Acl Type and Acl Mode fields.
Right now this is not the case. I can still edit these fields on the root dataset, but cannot edit them on first child.
| @@ -1452,6 +1454,10 @@ export class DatasetFormComponent implements FormConfiguration { | |||
| return false; | |||
| } | |||
|
|
|||
| isRootDataset(path: string): boolean { | |||
There was a problem hiding this comment.
we have isRootDataset in dataset.utils.ts that you can use here.
…ting first level dataset" This reverts commit a2c8b42.
|
@undsoft Done! Now it uses |
Summary
Removed ACL Type and Mode, if dataset is a root dataset , as suggested by the ticket's description