Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-117474 / 22.12 / Datasets table header sticky #7091

Merged
merged 7 commits into from
Sep 22, 2022
Merged

NAS-117474 / 22.12 / Datasets table header sticky #7091

merged 7 commits into from
Sep 22, 2022

Conversation

AlexKarpov98
Copy link
Contributor

No description provided.

@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 16, 2022 11:36
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-117474

@AlexKarpov98
Copy link
Contributor Author

@denysbutenko @undsoft - please have a look on these updates:

Screen.Recording.2022-09-16.at.14.39.27.mov

undsoft
undsoft requested changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
The only problem is that on some resolutions, when table has horizontal scrolling, header will be misaligned with columns.
Is this something we can fix?
Снимок экрана 2022-09-16 в 15 00 44

@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #7091 (ff0b7c7) into master (c1a62ad) will increase coverage by 0.72%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7091      +/-   ##
==========================================
+ Coverage   41.15%   41.88%   +0.72%     
==========================================
  Files        1045     1049       +4     
  Lines       46076    45400     -676     
  Branches     6395     6216     -179     
==========================================
+ Hits        18964    19017      +53     
+ Misses      27112    26383     -729
Impacted Files Coverage Δ
...dataset-management/dataset-management.component.ts 0.00% <0.00%> (ø)
src/app/pages/datasets/datasets.module.ts 0.00% <0.00%> (ø)
...form/components/form-array/form-array.component.ts 50.00% <0.00%> (-50.00%) ⬇️
src/app/services/shell.service.ts 6.52% <0.00%> (-5.48%) ⬇️
...p/pages/sharing/smb/smb-form/smb-form.component.ts 79.84% <0.00%> (-0.40%) ⬇️
src/app/services/ws.service.ts 17.03% <0.00%> (ø)
src/app/views/others/others.module.ts 0.00% <0.00%> (ø)
src/app/views/sessions/sessions.module.ts 0.00% <0.00%> (ø)
src/app/pages/network/network.component.ts 0.00% <0.00%> (ø)
src/app/modules/common/app-common.module.ts 0.00% <0.00%> (ø)
... and 53 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

denysbutenko
denysbutenko requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same issue

@AlexKarpov98
Copy link
Contributor Author

Could not find solution as well

@undsoft undsoft reopened this Sep 19, 2022
denysbutenko
denysbutenko requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kapture.2022-09-20.at.20.56.18.mp4

The dataset tree looks good now. Observed regression for dataset details panel. Also, the tree and details panel has different gaps at the bottom. It needs to be synced and probably reduced.

image

denysbutenko
denysbutenko reviewed Sep 20, 2022
View reviewed changes
src/app/pages/datasets/components/dataset-management/dataset-management.component.scss Outdated
@@ -318,3 +311,8 @@ $padding-left: 8px;
}
}
}

ix-tree {
max-height: calc(100vh - 330px);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What stands for 330px / How is it gained?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just calculated it visually, I think it will be good to refactor datasets blocks, to have same height via flex somehow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we like that approach I found, I'll work on refactoring

undsoft
undsoft requested changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous option was better. We wanted to keep page scrolling and not just have a smaller area to scroll.

@AlexKarpov98
Copy link
Contributor Author

@undsoft - reverted to previous solution

@AlexKarpov98
Copy link
Contributor Author

@undsoft @denysbutenko
It's done! 🥳 😎 ✅

Screen.Recording.2022-09-21.at.19.28.29.mov

undsoft
undsoft requested changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolling works perfectly now, nice work. 👍🏻

Need to revert changes to card widths to fix them.

src/app/pages/datasets/components/dataset-management/dataset-management.component.ts Outdated Show resolved Hide resolved
src/assets/styles/mixins/cards.scss Outdated Show resolved Hide resolved
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for denysbutenko September 22, 2022 10:12
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and undsoft and removed request for undsoft September 22, 2022 10:12
denysbutenko
denysbutenko approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work!

undsoft
undsoft approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird enough both times when I was testing this PR, I had to remove node_modules and reinstall packages. Just doing yarn would result in compilation error, not sure why.

May be worth doing the same and committing changed yarn.lock.

But generally works well.

@AlexKarpov98 AlexKarpov98 merged commit bd041f8 into master Sep 22, 2022
@undsoft undsoft deleted the feauture/NAS-117474-datasets-table-header-sticky branch August 1, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysbutenko denysbutenko denysbutenko approved these changes

@undsoft undsoft undsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexKarpov98 @bugclerk @denysbutenko @undsoft